Files
cryptoHermes/internal/repo/persistent/postgres/long_short_ratio_repo.go
dela ee420f9c56 test(postgres): pgxmock 覆盖 5 个 repo,包级 87.6%
为什么用 pgxmock:testcontainers 需要 docker-in-CI 而当前还没有 CI;
mock 路线 1) 零基础设施 2) 把 SQL 字符串和参数顺序作为契约锁死,
schema 漂移立刻可见——这正是上生产前最需要的信号。pgxmock 升级到
testcontainers 不阻塞 v2,留 v2.1 做 nightly 集成测试。

关键改动:
- internal/repo/persistent/postgres/pool.go:新建 pgxPool 接口,
  列出 5 repo 实际用到的 Begin/Query/Exec 三个方法。生产代码继续
  传 *pgxpool.Pool(自动满足接口),测试传 pgxmock.PgxPoolIface。
- 5 个 repo struct 字段从 *pgxpool.Pool 改为 pgxPool 接口;构造器
  签名保留 *pgxpool.Pool,app.go DI 不动。
- 5 个 *_repo_test.go:每个 repo 至少
  · UpsertMany happy path(精确 SQL + 参数)
  · UpsertMany 跳过逻辑(空字段 / 未收线)
  · UpsertMany ExecError(Rollback 路径)
  · FindRecent happy path(验证 DESC → 反序为升序)
  · FindRecent QueryError
  KlineRepo 额外加了 EmptyShortCircuits 和 BeginError 两个边界。

覆盖率:postgres 包 87.6%(UpsertMany ~86%、FindRecent ~93%)。
New*Repo 构造器为 0% 是设计选择:测试直接构造 struct 避开
*pgxpool.Pool 依赖。

所有 12 条守卫扫过无输出。
2026-05-24 20:43:46 +08:00

95 lines
2.3 KiB
Go

package postgres
import (
"context"
"fmt"
"github.com/jackc/pgx/v5/pgxpool"
"cryptoHermes/internal/entity"
)
type LongShortRatioRepo struct {
pool pgxPool
}
func NewLongShortRatioRepo(pool *pgxpool.Pool) *LongShortRatioRepo {
return &LongShortRatioRepo{pool: pool}
}
const lsUpsertSQL = `
INSERT INTO long_short_ratio (
source, symbol, period, ratio_type, timestamp,
long_short_ratio, long_value, short_value
) VALUES (
$1, $2, $3, $4, $5,
$6,
NULLIF($7, '')::NUMERIC,
NULLIF($8, '')::NUMERIC
)
ON CONFLICT (source, symbol, period, ratio_type, timestamp) DO UPDATE SET
long_short_ratio = EXCLUDED.long_short_ratio,
long_value = EXCLUDED.long_value,
short_value = EXCLUDED.short_value
`
func (r *LongShortRatioRepo) UpsertMany(ctx context.Context, items []entity.LongShortRatio) error {
if len(items) == 0 {
return nil
}
tx, err := r.pool.Begin(ctx)
if err != nil {
return err
}
defer tx.Rollback(ctx)
for _, ls := range items {
if ls.LongShortRatio == "" || ls.Timestamp == 0 {
continue
}
if _, err := tx.Exec(ctx, lsUpsertSQL,
ls.Source, ls.Symbol, ls.Period, ls.RatioType, ls.Timestamp,
ls.LongShortRatio, ls.LongValue, ls.ShortValue,
); err != nil {
return fmt.Errorf("upsert ls %s/%s/%s@%d: %w", ls.Symbol, ls.Period, ls.RatioType, ls.Timestamp, err)
}
}
return tx.Commit(ctx)
}
const lsFindSQL = `
SELECT source, symbol, period, ratio_type, timestamp,
long_short_ratio::text,
COALESCE(long_value::text, ''),
COALESCE(short_value::text, '')
FROM long_short_ratio
WHERE symbol = $1 AND period = $2 AND ratio_type = $3
ORDER BY timestamp DESC
LIMIT $4
`
func (r *LongShortRatioRepo) FindRecent(ctx context.Context, symbol, period, ratioType string, limit int) ([]entity.LongShortRatio, error) {
if limit <= 0 {
limit = 100
}
rows, err := r.pool.Query(ctx, lsFindSQL, symbol, period, ratioType, limit)
if err != nil {
return nil, err
}
defer rows.Close()
out := make([]entity.LongShortRatio, 0, limit)
for rows.Next() {
var ls entity.LongShortRatio
if err := rows.Scan(&ls.Source, &ls.Symbol, &ls.Period, &ls.RatioType, &ls.Timestamp,
&ls.LongShortRatio, &ls.LongValue, &ls.ShortValue); err != nil {
return nil, err
}
out = append(out, ls)
}
for i, j := 0, len(out)-1; i < j; i, j = i+1, j-1 {
out[i], out[j] = out[j], out[i]
}
return out, rows.Err()
}